fix #35851 : paste a chordrest crossing the barline of an irregular meas... #1360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Travis copypaste test was failing because I changed the policy for inserting rests when they are splitted. Now dots are not used. Probably the sequence by which splitted rests and notes are inserted is still suboptimal (i.e. in some cases the sequence should be reversed: from the smallest duration to the largest instead of the opposite, as it now happens). |
AntonioBL
force-pushed
the
paste_chordrest
branch
from
6c7f7bf
to
57dc1be
Compare
|
In fact toDurationList should probably take into account the current time signature. 6/8, 9/8 etc... definitely prefer dotted rests... |
lasconic
added a commit
that referenced
this pull request
Nov 7, 2014
fix #35851 : paste a chordrest crossing the barline of an irregular meas...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...ure