A few bug fixes and improvements to system header and brackets #13634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mike-spa
commented
Oct 5, 2022
mike-spa
commented
- The distance of staff names to the system should scale not only with the staff size (as it does now) but also with text size (taking into account the possibility that the text size may not "follow staff size").
- Indentation of the first system should not include the brackets width.
- Square brackets should never appear on a single staff, even if "show bracket if spanning a single staff" is enabled. So I've created a dedicated style setting for square brackets (not exposed).
- The begin bar line of a system should not be drawn if the system has only one visible staff. At the moment, it was working correctly only if the score itself has just the one staff.
mike-spa
force-pushed
the
systemBracketsImprovements
branch
4 times, most recently
from
93bbfa7
to
d1bb175
Compare
oktophonie
approved these changes
Oct 6, 2022
mike-spa
force-pushed
the
systemBracketsImprovements
branch
3 times, most recently
from
074b469
to
778f21e
Compare
|
@cbjeukendrup I get this weird u-test failur where it seems to crash or something, but I don't understand why it's happening and I can't reproduce it locally. Any idea what's going on? |
Has #13713 solved the problem? |
|
Yes, should be fine after a rebase now! |
mike-spa
force-pushed
the
systemBracketsImprovements
branch
from
778f21e
to
1c4c7f9
Compare
correction
correction correction correction
correction
mike-spa
force-pushed
the
systemBracketsImprovements
branch
from
1c4c7f9
to
975c5b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.