Fix #36451 : Alla breve forced to 2/2

[mgavioli]

Fix #36451 : Alla breve forced to 2/2

Basically reverts commit 7ab8acd which was intended to fix issue http://musescore.org/en/node/14548 (apparently no longer needed)

Fix code is kept but commented out, with detailed comment and a small addition, in case the original issue pops up again in the future.

See http://musescore.org/en/node/36541 for more details, score samples and discussion.

[mgavioli]

Hmmm... the fact is that I distinctively dislike code which alters what the user had set. In your specific case, you didn't set anything, it was a previous bug. But a time sig. with 4/4 values and alla breve symbol is possible via the time sig. props dlg box and that code would wipe it out.

I do not have a use case for it right on the spot, but I didn't have use cases for many features other people requested and many peoples did not know (or think) about time sigs requirements like the score I posted in the issue tracker.

So, I am worried about such a kind of code, in itself and as a possibly dangerous precedent.

[Jojo-Schmitz]

Ah, I see, and agree :-)

[lasconic]

could we just delete the code and put this comment in the issue tracker for the related issues? it feels a bit weird to have all this in the code, and I'm not a big fan of seeing this kind of things a little bit everywhere. Also, one day, this comment will just be deleted and lost (except for git history), while in the issue tracker it would remain "forever".

[mgavioli]

If this is the policy of the 'company', ok. Comment removed.

However, it is true that in the tracker the info will remain "forever", but it is unlikely that someone thinking about adding back a similar code will look for that info in old, potentially not clearly related, bug discussions.

[lasconic]

Not a policy, just my personal opinion.

[lasconic]

The bug in question is #36541 not #36451