Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #13809 french clefs switch #13813

Merged
merged 1 commit into from Oct 27, 2022
Merged

fix #13809 french clefs switch #13813

merged 1 commit into from Oct 27, 2022

Conversation

sammik
Copy link
Contributor

@sammik sammik commented Oct 18, 2022 •
edited

Resolves: #13809

fixes typo in types.h (reverted order of C1 and C3) and coresponding clef.cpp.

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

@DmitryArefiev
Copy link
Contributor

Tested #13809 on Win10, Mac12, LinuxUbuntu 22.04 - FIXED

@DmitryArefiev DmitryArefiev mentioned this pull request Oct 27, 2022
Closed
@DmitryArefiev
Copy link
Contributor

@sammik Thanks for fixing!

@DmitryArefiev DmitryArefiev merged commit 431ddb3 into musescore:master Oct 27, 2022
@sammik sammik deleted the fix#13809_french_clefs branch October 27, 2022 18:39
@sammik sammik mentioned this pull request Nov 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RomanPudashkin RomanPudashkin RomanPudashkin approved these changes

Assignees

@DmitryArefiev DmitryArefiev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Alto/Soprano Clef (French, 20th century) Switch
3 participants
@sammik @DmitryArefiev @RomanPudashkin