Inspector: Avoid using "notehead type" to mean different things #14154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already use "notehead type" to mean the shape of the notehead so we shouldn't use it to mean the duration as well. This affects the Note Inspector and the Ambitus Inspector.
shoogle
force-pushed
the
notehead-visual-duration
branch
from
ef30aa7
to
291d27b
Compare
|
@Tantacrul, this is what was proposed on Discord. I found it affects the Ambitus Inspector as well as the Note Inspector. |
|
Looks good |
RomanPudashkin
approved these changes
Oct 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already use "notehead type" to mean the shape of the notehead so we shouldn't use it to mean the duration as well. This affects the Note Inspector and the Ambitus Inspector.
Ambitus
In the Properties panel, "Notehead type" becomes "Notehead duration" where appropriate.
Notes
In the Properties panel, "Notehead type (visual only)" becomes "Override visual duration" to indicate that this option changes the visual appearance of the notehead without affecting playback or horizontal spacing.