fix #38501: cheap partial fix for cross-staff and cross-system gliss #1439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ross-system gliss
lasconic
added a commit
that referenced
this pull request
Nov 11, 2014
fix #38501: cheap partial fix for cross-staff and cross-system gliss
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses both http://musescore.org/en/node/38501 and http://musescore.org/en/node/3811 (replacing an earlier closed PR for the latter). It's only a partial fix for both issues, as you can see from the vtests, but it's a heck of a lot better than what we do now. There has been talk of updagting the glissando implementation in a way that would allow for a full solution, but its kind of looking less and less likely that we'll see that for 2.0, so I would like to have this as a fallback.