fix #40846: require Ctrl+drag to create staff-only barline change #1510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe @mgavioli has some insights? |
lasconic
added a commit
that referenced
this pull request
Dec 10, 2014
fix #40846: require Ctrl+drag to create staff-only barline change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 1.3, you could change to a double bar or other barline style by clicking the barline then double clicking the palette icon. In 2.0, this behavior has changed - the abrline is applied only to the current staff. Unless you know the trick of dragging the palette icon to the measure, it looks like you need to apply the barline to each staff one at a time, which would be as bad as when we had to apply key signatures one staff at a time in 1.3. Worse, barlines applied in this manner "hide" repeat barlines, leading to the issue at hand: http://musescore.org/en/node/40846
Since we have already established the convention with key & time signatures of having ordinary drop affect the whole system but Ctrl+drop affects just the current staff, I have implemented this for barlines as well. I am keeping the special casing for the "tick" styles - they always affect the current staff only even if dragged to the measure.
I tested this as well as I could, but I admit I don't understand all the ins and outs of the barline implementation. But I can verfy that drag of each barline from palette to a measure works as expected, as do Ctrl+drag and double click.