Fix #15038: Recompute default stem length when hook is added #15117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good; it is also necessary to re-render when stem directions change. When the first note of a) is split from the group, for example, we get b). (The stem direction should flip, which does happen when the layout is recomputed.) |
asattely
force-pushed
the
break-beam-refresh
branch
2 times, most recently
from
4c99b65
to
805eb90
Compare
oktophonie
approved these changes
Dec 13, 2022
asattely
force-pushed
the
break-beam-refresh
branch
from
805eb90
to
517c793
Compare
|
@asattely please pay attention to the failed utests |
asattely
force-pushed
the
break-beam-refresh
branch
from
517c793
to
359bde3
Compare
RomanPudashkin
approved these changes
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #15038
Resolves: #14569
The stems were poorly sized because the computation for stem length came before any beams were removed / hooks were added. Now there is a recalculation of stem length.