New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Narrow spacing improvements #15174
Narrow spacing improvements #15174
Conversation
8e6a705
to
a0f4efc
Compare
a0f4efc
to
dc71a44
Compare
5571da5
to
e53324f
Compare
0021c78
to
51d6e59
Compare
51d6e59
to
b8ac423
Compare
b8ac423
to
d8954e5
Compare
@RomanPudashkin yeah, I know it's extremely inefficient, but it's the only way to squeeze everything while still producing an acceptable engraving result. The good news is that Besides that, I've removed the calls to minSysTicks and maxSysTicks cause I've realized that the values could be passed down by the caller. And I've added comments on the constants. |
d8954e5
to
51e7235
Compare
@mike-spa The vtests check hangs up on this PR. Please take a look at it |
4920c15
to
590b080
Compare
Ok, I don't understand why the vtests seem to get stuck: I can run them locally on my machine (Windows) and they run fine. I'll try on my Linux machine and see if something changes. |
590b080
to
52f68dd
Compare
Update on vtests: they run perfectly fine both on my Windows machine and on my Linux machine. So I really don't know what to do with them here |
@mike-spa Please, disable (comment out) the drawdata steps so they don't block you (they are in alpha mode now), I'll see what's wrong later https://github.com/musescore/MuseScore/blob/master/.github/workflows/ci_vtests.yml#L153 |
101fd32
to
45de81c
Compare
Clefs are extremely annoying, because they are literally the only musical item that is spaced right-to-left, while the whole system is designed to space left-to-right. Previously, I had kind of hacked into it. The only real solution, though, is to split the spacing in 2 passes. Pass 1: place all the left-aligned segments. Pass 2: place all the right-aligned segments (basically, clefs and breaths). correction
Otherwise what's the point of noBreak...
resolve conflict
45de81c
to
59ee813
Compare
Ok, I've removed the problematic bit from the vtests and rebased it, let's hope it works 👍 (btw the current master crashes on startup) |
Being able to force measures into a system is a heavy new feature! Thanks for introducing this into MuseScore. |
Narrow spacing improvements (and a few related things).
Before:
before.mp4
After:
after.mp4