fix #41906: make screenshot mode rectangle appear within current view #1519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| qreal h = height() / _matrix.m22(); | ||
| _foto->setRect(QRectF(w * .3, h * .3, w * .4, h * .4)); | ||
| // try to find existing rect within current view | ||
| QRectF view(-xoffset() / _matrix.m11(), -yoffset() / _matrix.m22(), width() / _matrix.m11(), height() / _matrix.m22()); |
There was a problem hiding this comment.
Somehow this seems way more complex than it should be. There is not a simple "currentRect()" function to return the current view in canvas coordinates?
There was a problem hiding this comment.
toLogical() in ScoreView? Apparently it's how we draw the visible zone in the navigator.
MarcSabatella
force-pushed
the
41906-screenshot-page
branch
from
d90c660
to
38c1f5b
Compare
|
Yep, toLogical() works, now that I know what parameters to pass. |
lasconic
added a commit
that referenced
this pull request
Dec 10, 2014
fix #41906: make screenshot mode rectangle appear within current view
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When enabling screenshot mode, center rectangle in current view unless previous rectangle exists and would be within view.
I'm totally comfortable with the logic here. What I don't know is if there is better way of obtaining the rectangle corresponding to the current view. See my line comment.