Fix #15229: Allow beam breaks on beam-inset rests #15387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asattely
changed the title
oktophonie
approved these changes
Dec 20, 2022
asattely
force-pushed
the
break-beam-over-rest
branch
from
b41eaf4
to
01f0755
Compare
|
@asattely please rebase it |
RomanPudashkin
approved these changes
Mar 20, 2023
previously, this was not possible
asattely
force-pushed
the
break-beam-over-rest
branch
from
01f0755
to
43327a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #15229
There are several vtests that are failing on this one, but all of the failures are due to the rests having regular "continued beam" properties on them, rather than one of the inner beam break options. It is now possible, by using the break inner beams properties, to recreate what the reference vtests show. We can modify those vtests to look like they did before by breaking inner beams on the rests, but for the time being, the vtest differences show what I believe we would expect when the rests' beam properties are set to the regular non-broken
join beamssetting.