Avoid overlapping brackets #15514
Merged
Avoid overlapping brackets #15514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oktophonie
approved these changes
Dec 22, 2022
src/engraving/libmscore/edit.cpp
Outdated
| // Make sure this brackets won't overlap with others sharing same column. | ||
| // If overlaps are found, move the other brackets outwards (i.e. increase column). | ||
| for (staff_idx_t staffIdx = startStaffIdx; staffIdx < startStaffIdx + span && staffIdx < totStaves; ++staffIdx) { | ||
| for (BracketItem* bracketItem : staves().at(staffIdx)->brackets()) { |
There was a problem hiding this comment.
You should use _staves directly here
|
@mike-spa please rebase it |
RomanPudashkin
approved these changes
Mar 1, 2023
correction
mike-spa
force-pushed
the
bracketsCorrection
branch
from
db6e1d4
to
9ac9070
Compare
|
Oops, lost sight of this one! Done and rebased 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #15456