Fix MMRest bug #15778
Merged
Fix MMRest bug #15778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-spa
force-pushed
the
fixMMRestBug
branch
from
522a70a
to
aae4fe5
Compare
oktophonie
approved these changes
Jan 10, 2023
mike-spa
force-pushed
the
fixMMRestBug
branch
from
aae4fe5
to
c69394c
Compare
mike-spa
force-pushed
the
fixMMRestBug
branch
2 times, most recently
from
53183c8
to
f0189d8
Compare
|
@mike-spa any new vtests/utests? |
|
@RomanPudashkin the changes show up in many of the existing vtests already (basically, all that contain MMRests), so there's no need to add more. They are going all green just cause @oktophonie put the vtest label on this PR :) |
|
(I even checked the vtests again to be sure, the changes still all look beautiful to me.) |
RomanPudashkin
approved these changes
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #15561
The issue was, in part, due to a couple of errors in the handling of the MMRest themselves (specifically, not correctly taking into account items before the MMRest but in the same bar) . Those are now fixed. The vtests differences will show the corrected results.
The other part is more trivial, i.e. that the minimum width for MMRests is set by default to 4 sp (Style -> Rests). This makes no sense, given that the minimum width for normal measures is 8sp and MMRests should never be narrower than normal measures. I propose raising the default value to 6sp. Considering that MMRests also have two enforced margins that are set by default at 1.2sp, the resulting minimum possible width of an MMRests measure is 8.4sp, which ensures they can never be narrower than a single empty measure.