Fix magnification issues #15949
Merged
Fix magnification issues #15949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oktophonie
approved these changes
Jan 19, 2023
mike-spa
force-pushed
the
fixMagnificationIssues
branch
from
518ea9e
to
3837cc3
Compare
oktophonie
approved these changes
Feb 23, 2023
mike-spa
force-pushed
the
fixMagnificationIssues
branch
from
3837cc3
to
0c9484f
Compare
RomanPudashkin
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #15859
Resolves: #16495
The first commit deals with a general problem that we have in Musescore: when calling the mag() method, some items return their own magnification, but others return their magnification multiplied by the staff magnification. The problem is with chords in particular. When needing the "intrinsic" magnification of chords (meaning, independent of the staff) people made different methods and there was even a duplicate (Chord::chordMag() and Chord::relativeMag() were doing the same thing). I have cleaned up the duplicate, and made a virtual method in ChordRest called intrinsicMag() that is then implemented by chords and rests.
The other commits contain the actual fixes.