Show melisma line after first underscore #1636
Conversation
|
What would you think about implementing what we mentioned on IRC - making it so hitting Space on an existing lyric with melisma deleted it? Presumably just a matter of setting ticks to 0 in lyricsTab. I guess the question in my mind is whether this is "expected". I could see an argument for saying space should be a non-destructive navigation command like it is for chord symbols. But we already clear out the hyphens. |
|
As far as I can tell it is already so, at least for the majority of the scores I tried this trick on and, in any case, it was intended to be so. There are a few for which this does not seem to work; I have not found a pattern for this, but I'm confident I (or we) will. |
|
Really? It never works for me. It works for hyphens, but not underscores. Maybe we are talking about two different things? If I have a syllable with a melisma line, then double click that syllable and press space, the line remains. And looking at the code in lyricsTab(), I can see why - at no point is there any code to reset the oldLyrics tick count to 0. We would need an uncoChangeProperty to set LYRICS_TICKS to 0 right at the same place we currently change the syllabic propert of the old & new lyric. |
|
Well, it mostly works for me (using current or yesterday master): lyrics ticks are set to 0 by the So far, the examples where it works are in non-first staff (rather common in polyphony), while the examples where it does not works are in first (or only) staff; I cannot say if this is relevant or just a chance. Still investigating... EDIT: well, the difference is if the syllable with melisma has a syllabic dash before or not (it is the last of a multi-syllable word or not; the first case being rather common in Italian); in the first case |
|
Hah, thanks, knowing the it actually happens in endEdit (or more specifically lyricsEndEdit() just led to me to the answer. Last three lines ScoreView::lyricsEndEdit - ticks is only set to 0 if the syllable is Syllabic::END! So, only the last syllable of a multi-syllable word, not a single syllable word. |
|
I have the code ready for this fix. About to push it, unless you want to do it. |
|
Nah, do it! |
|
Needs a rebase... |
While entering a melisma, the first underscore has no specific visual effect. This patch displays a short melisma after the first underscore, by setting a conventional non-0 lyrics `_ticks` value. Note: If no second underscore is entered (edit mode is exited or a new syllable is entered in the following chord), the short melisma is left behind as a left-over. It may be the case to reset to 0 the melisma ticks (= no melisma at all) for instance when the score is saved, or read back.
|
@Jojo-Schmitz @wschweer : rebased (rather trivial: I wonder why git couldn't do it by itself...) |
…score Show melisma line after first underscore
While entering a melisma, the first underscore has no specific visual effect.
This patch displays a short melisma after the first underscore, by setting a conventional non-0 lyrics
_ticksvalue.Note: If no second underscore is entered (edit mode is exited or a new syllable is entered in the following chord), the short melisma is left behind as a left-over. It may be the case to reset to 0 the melisma ticks (= no melisma at all) for instance when the score is saved, or read back.