Do not enter melisma(s) over rests #1637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If underscore is pressed on a lyrics followed by rest(s), the previous melisma line is extended across the rests. This patch stops the melisma before the rests, while still placing the lyrics cursor after the rests ready to enter a new syllable.
|
Interesting! FYI, I was just working on http://musescore.org/en/node/44291, and noticed that deleting notes at the tail end of a melisma leaves you with melisma over rests. I can take care of that in the code I am working on, which is basically working. I don't see any conflict with what you are doing here; I think the changes will complement each other nicely. |
wschweer
added a commit
that referenced
this pull request
Jan 19, 2015
Do not enter melisma(s) over rests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If underscore is pressed on a lyrics followed by rest(s), the previous melisma line is extended across the rests.
This patch stops the melisma before the rests, while still placing the lyrics cursor after the rests ready to enter a new syllable.