Fix cross system slur direction bug #16572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oktophonie
approved these changes
Feb 27, 2023
mike-spa
force-pushed
the
fixCrossSystemSlurDirectionBug
branch
from
8689630
to
2fa006b
Compare
RomanPudashkin
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #16571
This is yet another example of our layout system working against us. Because the system works one measure at a time, one system at a time, and so on, if the end chord of a slur is on a different system, the chord has never been laid out yet by the time we're computing the layout of the slur, so we don't know its direction to decide the slur direction. The only way to fix this issue is by hacking it, and anticipating some of the layout operations of the end chord.