fix #17906: chord MIDI input is fixed #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or is moved back before adding each subsequent note after the first, so that all of them become part of the same chord at the same position; the 'active' variable in MuseScore::midiNoteReceived() is used in a comparison, instead of directly as a parameter, since sometimes it can be -1
wschweer
added a commit
that referenced
this pull request
Jan 21, 2013
fix #17906: chord MIDI input is fixed
|
This pull request got merged, but this one #166 got too. |
heuchi
pushed a commit
to heuchi/MuseScore
that referenced
this pull request
Nov 13, 2013
fix musescore#17906: chord MIDI input is fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix http://musescore.org/en/node/17906 - I'm new to MuseScore source code, this may not be the best solution