fix #45176: bad barline span in parts #1674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The first commit fixes the problem at the source, by getting the barline span right when generating the parts. The second commit fixes existing scores that might have been saved with earlier builds. There were already some barLineSpan sanity checks; I just hooked in and added another. I would note that for all fo these checks, even though we are correcting the spans for the staves, the individual barlines may also have been written incorrectly. Not sure it's worth worrying about that. |
wschweer
added a commit
that referenced
this pull request
Jan 26, 2015
fix #45176: bad barline span in parts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.