Search box/filter added to the instrument list #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can see that the Travis build failed but I can't see the error log when clicking "Details". It just says loading... It builds without errors on my system (Kubuntu 12.04) |
|
The travis build system got a hiccup. There is no problem. Thanks for the patch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a search box / filter to the instrument dialog and the new wizard. It is a simple linear search which gives good performance on my computer. This could be improved in the future if needed.
This feature is requested here http://musescore.org/en/node/18542
The filterInstruments() functions is placed in the instrdialog.cpp file, but probably it should be placed somewhere else.
I'm very open to suggestions, improvements, comments, etc.