Fingering vs articulation #16972
Merged
Fingering vs articulation #16972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oktophonie
approved these changes
Mar 22, 2023
|
@mike-spa Seems like there's a regression in this PR. abariska.2023-03-22.at.19.41.03.mp4 |
|
That regression is unrelated to this PR I think - it's evident in the latest nightly, which doesn't contain this, so it'll be a byproduct of one of the many other PRs that's been merged recently. We can investigate that separately. |
|
It can't reproduce in the nightly build from date 21/03. I didn't check yesterday's nightly |
|
That regression is caused by #16078. I'll work on it now |
RomanPudashkin
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #15648
The reason for the bug is quite trivial: we need to layout articulations before fingering, not the other way around.
I've also found the code around this area to be quite messy, so I've done some basic reorganization by extracting the fingering code (which has no point in being in LayoutSystem) into its own function LayourChord::layoutChordBaseFingering(), and made sure that things are called in the right order.
Before:
After:
