Fix #16497: Include placement attributes for non-string harmonics in <technical> elements #17033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asattely
force-pushed
the
mxml-articulation-placement
branch
from
1cb8ad9
to
bd9c6b0
Compare
oktophonie
approved these changes
Jul 11, 2023
|
@asattely please rebase it |
RomanPudashkin
approved these changes
Jul 11, 2023
Merged
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Nov 7, 2023
Backport of musescore#18556, part 1 resp. musescore#17033
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Nov 7, 2023
Backport of musescore#18556, part 1 resp. musescore#17033
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Nov 7, 2023
Backport of musescore#18556, part 1 resp. musescore#17033
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Nov 7, 2023
Backport of musescore#18556, part 1 resp. musescore#17033
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Nov 7, 2023
Backport of musescore#18556, part 1 resp. musescore#17033
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Nov 7, 2023
Backport of musescore#18556, part 1 resp. musescore#17033
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Nov 14, 2023
Backport of musescore#18556, part 1 resp. musescore#17033
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #16497
For some reason the only elements inside
<technical>tags that saved placement information was string harmonics. The circle articulations in the file included in the issue are brass markings. This fix saves placement information for any technical articulation in the same way as normal articulations, regardless of symbol.