Implement #17037: Replacement of 'b' and '#' with '♭' and '♯' for staff names imported from mxml #17118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asattely
force-pushed
the
mxml-accidentals-in-staff-names
branch
4 times, most recently
from
3d2a40a
to
484f0d6
Compare
|
Updated to add transpositions in non-english languages, such as Si♭, in addition to the note name. Also made it non-case sensitive (though the b is still case-sensitive) |
asattely
force-pushed
the
mxml-accidentals-in-staff-names
branch
from
484f0d6
to
3f2f8ff
Compare
asattely
force-pushed
the
mxml-accidentals-in-staff-names
branch
from
3f2f8ff
to
dc3dd9d
Compare
asattely
force-pushed
the
mxml-accidentals-in-staff-names
branch
2 times, most recently
from
a4e4a16
to
c876eda
Compare
oktophonie
approved these changes
May 4, 2023
asattely
force-pushed
the
mxml-accidentals-in-staff-names
branch
from
c876eda
to
91e5b14
Compare
asattely
force-pushed
the
mxml-accidentals-in-staff-names
branch
from
91e5b14
to
5bf7ca1
Compare
| @@ -425,6 +425,7 @@ class Instrument | |||
| void setIsPrimary(bool isPrimary); | |||
|
|
|||
| void updateInstrumentId(); | |||
| void updateNamesForAccidentals(); | |||
There was a problem hiding this comment.
Please remove this line (it is not needed)
| @@ -53,6 +53,34 @@ static int musicXMLImportErrorDialog(QString text, QString detailedText) | |||
| return errorDialog.exec(); | |||
| } | |||
|
|
|||
| void updateNamesForAccidentals(Instrument* inst) | |||
There was a problem hiding this comment.
static void updateNamesForAccidentals(Instrument* inst)
Merged
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Nov 7, 2023
…t in insrt names Backport of musescore#18556, part 4, resp. musescore#17118 Disabled for now, needs more work
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Nov 7, 2023
…t in insrt names Backport of musescore#18556, part 4, resp. musescore#17118 Disabled for now, needs more work
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Nov 7, 2023
…t in insrt names Backport of musescore#18556, part 4, resp. musescore#17118 Disabled for now, needs more work
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Nov 7, 2023
…t in insrt names Backport of musescore#18556, part 4, resp. musescore#17118 Disabled for now, needs more work
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Nov 7, 2023
…t in insrt names Backport of musescore#18556, part 4, resp. musescore#17118 Disabled for now, needs more work
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Nov 8, 2023
…t in insrt names Backport of musescore#18556, part 4, resp. musescore#17118 Disabled for now, needs more work
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Nov 8, 2023
…t in insrt names Backport of musescore#18556, part 4, resp. musescore#17118 Disabled for now, needs more work
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Nov 14, 2023
…t in insrt names Backport of musescore#18556, part 4, resp. musescore#17118 Disabled for now, needs more work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #17037
This replaces b and # with their unicode equivalents during musicxml import iff:
As is pointed out in a comment on the original issue, there is an import option available to replace (or not replace) fonts. This PR does not override that setting, and doesn't touch font stuff at all.