Enhance tuplet direction detection based on voices #17520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oktophonie
approved these changes
May 10, 2023
| @@ -92,7 +92,7 @@ void TupletLayout::layout(Tuplet* item, LayoutContext&) | |||
| // find out main direction | |||
| // | |||
| if (item->_direction == DirectionV::AUTO) { | |||
| int up = 1; | |||
| int up = 0; | |||
asattely
force-pushed
the
empty-tuplets-direction
branch
from
85d334e
to
36df994
Compare
RomanPudashkin
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #16874
Empty tuplets would always default to 'up' as their auto direction, even when in voices 2 and 4. Now voices 2 and 4 empty tuplets face downwards.
I also noticed a TODO comment in there for nested tuplets, which I also replaced with some simple logic to make sure that the outer tuplet follows the direction of the inner ones (which are laid out first).