Partial fix #17623: Null check for stemside artic placement on stemless chords #17635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbjeukendrup
approved these changes
May 18, 2023
|
@asattely Reg. the other crash, I assume you mean Michele's PR, right? |
oktophonie
approved these changes
May 18, 2023
|
One more thing, shouldn't we add a VTest or unit test that covers this case? |
|
A vtest has been added! (A failure is not shown because the previous build actually fails to complete the PNG generation step due to crash, but the vtests for this branch build and function appropriately) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially resolves: #17623
The Szymanowski score was a simple null check, so I'm pushing that here. The other example score from that issue is related to some major changes that are taking place, and the fix for that one will be folded into a different PR in the near future.