Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GH#17659: OGG export always at 48000 Hz #17694

Merged
merged 1 commit into from Jun 26, 2023
Merged

Fix GH#17659: OGG export always at 48000 Hz #17694

merged 1 commit into from Jun 26, 2023

Conversation

Jojo-Schmitz
Copy link
Contributor

Resolves: #17659

Fixed by disabling the corresponding part of the dialog, as apparently OGG Opus doesn't allow for setting a sample rate

@Jojo-Schmitz
Copy link
Contributor Author

But see also #15788

@Jojo-Schmitz
Copy link
Contributor Author

Jojo-Schmitz commented Jun 16, 2023 •
edited

Can this please get rewiewed and merged?

@Jojo-Schmitz
Copy link
Contributor Author

@bkunda mind to approve so we can get it into 4.1.0?

@Jojo-Schmitz Jojo-Schmitz mentioned this pull request Jun 26, 2023
Merged
@bkunda
Copy link

bkunda commented Jun 26, 2023

Tested on macOS and Win. Fixed.

@bkunda
Copy link

bkunda commented Jun 26, 2023

I should mention that I am experiencing playback a tone lower than written on Win at the moment, but I have experienced this outside of this PR (in the beta build), so I suspect it is not consequential to this PR. At any rate, the OGG files were exported at the (correct) written pitch, notwithstanding the playback pitch in the app.
Am still trying to get this bug to a reproducible state, but will raise it separately when I can.

@cbjeukendrup cbjeukendrup merged commit 0d3e3cf into musescore:master Jun 26, 2023
11 checks passed
@cbjeukendrup
Copy link
Contributor

@bkunda Maybe it has something to do with switching between different audio devices? Anyway, it is impossible that it is caused by this PR, since it only touches some UI code in the Export dialog.

@Jojo-Schmitz Jojo-Schmitz deleted the ogg-export-sample-rate branch June 26, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbjeukendrup cbjeukendrup cbjeukendrup approved these changes

Assignees

@bkunda bkunda

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OGG export always at 48000 Hz
3 participants
@Jojo-Schmitz @bkunda @cbjeukendrup