Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use newer Qt version on macOS #17772

Merged
merged 1 commit into from Jun 9, 2023
Merged

Conversation

cbjeukendrup
Copy link
Contributor

@cbjeukendrup cbjeukendrup commented May 29, 2023

Resolves: #16533
Resolves: #17740

@bkunda
Copy link

bkunda commented Jun 9, 2023

I've been able to verify that the spaces are now working as they are supposed to. So glad this has been fixed!
I was unfortunately unable to verify whether #17740 has been properly fixed by this (as far as I can tell, the behaviour in this build is the same as in the latest nightly). Perhaps @bakajikara can verify?

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jun 9, 2023
@bakajikara
Copy link
Contributor

bakajikara commented Jun 9, 2023

@bkunda Yes, I've rechecked the build now and it's working as expected!
(The behavior depends on macOS's preferred language setting; if both Japanese and Korean are not on the list, it will use Chinese glyphs as default.)

@bkunda
Copy link

bkunda commented Jun 9, 2023

ok great!
Then @cbjeukendrup I think we may be ready to go with this one!

@cbjeukendrup cbjeukendrup merged commit 644a78d into musescore:master Jun 9, 2023
11 checks passed
@cbjeukendrup cbjeukendrup deleted the new_qt_mac branch June 9, 2023 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants