Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix translatable texts: "bar line(s)" to "barline(s)" #17782

Merged
merged 1 commit into from Jun 9, 2023

Conversation

Jojo-Schmitz
Copy link
Contributor

No description provided.

@cbjeukendrup cbjeukendrup added the strings Affects translatable strings label Jun 8, 2023
@bkunda
Copy link

bkunda commented Jun 9, 2023

@cbjeukendrup I'd be satisfied if we used "barline(s)" instead of "bar line(s)".
Certainly, there is a bit of variety out there (Oxford even uses "bar-line"!), so all we can aim for is consistency throughout the app.

@Jojo-Schmitz
Copy link
Contributor Author

Jojo-Schmitz commented Jun 9, 2023

Yes, this change is just for consistency, matching other occurrences of the same term.
If we'd decide to use "bar line(s)" or "bar-line(s)", we should do it all the way, but a long time ago it was decided to go for "barline(s)"

@bkunda
Copy link

bkunda commented Jun 9, 2023

I am happy with "barline(s)"

@cbjeukendrup cbjeukendrup merged commit 939fefc into musescore:master Jun 9, 2023
11 checks passed
@Jojo-Schmitz Jojo-Schmitz deleted the translations branch June 10, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
strings Affects translatable strings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants