Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move stuff into setNotation and call setNotation from onCurrentNotationChanged #17858

Merged
merged 1 commit into from Jun 6, 2023
Merged

Move stuff into setNotation and call setNotation from onCurrentNotationChanged #17858

merged 1 commit into from Jun 6, 2023

Conversation

mike-spa
Copy link
Contributor

@mike-spa mike-spa commented Jun 5, 2023

Resolves: #17596

Basically, what @cbjeukendrup suggested here.

cbjeukendrup
cbjeukendrup approved these changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@cbjeukendrup cbjeukendrup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future, when necessary, we could also move onUnloadNotation(m_notation); and onLoadNotation(m_notation); to setNotation, but I think it's fine to not do that right now.

@zacjansheski
Copy link
Contributor

Tested and working well! MacOS 11.6.5, Windows 11, Ubuntu 20.04.6

@RomanPudashkin RomanPudashkin merged commit 14387b1 into musescore:master Jun 6, 2023
11 checks passed
@Eism Eism mentioned this pull request Jun 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbjeukendrup cbjeukendrup cbjeukendrup approved these changes

@RomanPudashkin RomanPudashkin RomanPudashkin approved these changes

Assignees

@zacjansheski zacjansheski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash if you save a template in continuous view
4 participants
@mike-spa @zacjansheski @cbjeukendrup @RomanPudashkin