fix #48336: musejazz exports as bold on windows #1832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcSabatella
force-pushed
the
48336-musejazz-book
branch
from
fb265f0
to
8430731
Compare
|
Again an awesome investigation ! Thanks! |
lasconic
added a commit
that referenced
this pull request
Mar 3, 2015
fix #48336: musejazz exports as bold on windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After (more than) a bit of trial error, I discovered that setting the weight of MuseJazz to "Book" instead of "Medium" solves the PDF export problem on Windows - MuseJazz exports as normal rather than bold. Works on Linux too, should work on Mac.
Along the way, I discovered two glyphs ("a" and "]") had some issues that could cause glitches rendering them as bold, so I fixed those as well.
It's still the case that if you actually do go out of your way to use bold face with MuseJazz on Linux (not on Windows), Qt uses a different weight for onscreen display versus print or PDF output. The weight used for print & PDF looks like it does on Windows, but on screen display is bodler still. This was the case before my change as well. But it's a much less important issue than the one I am fixing - PDF export on Windows will finally be where it needs to be for release!