Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After reading a number of recommendations, I opted for a fairly subtle fix, just limiting the beam slant to 1sp for two-note beams. Gould talks of limiting it further depending on how crowded the spacing is, but that's not easy for us to do.
BTW, while fixing this, I discovered a couple of places where our beams were really strange. The first measure of the vtest I created actually shows cases where, in addition to issues with the beam angle, the stems were too short or two long overall. I think there were just some bad values in the table of beam metrics. I didn't do a super through job of it, but I tried different intervals transposed to different staff lines, and I fixed the most obvious cases.
This is not an area of code I know well, so I definitely would appreciate review, but it does seem to do what it is supposed to do. I tried changing the sixteenth note portion of the code to limit the slant to 0.5sp, but the subsequent code that calculates stem lengths doesn't seem to handle this, so I arrive at the values for minS and maxS I have empirically. I'm less confident about that paet of the change than the eighth note part..