Fix #48436 - Lyrics melisma and deleting measures / Fix #48491 - Ditto and time change #1865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cs melisma and time change **Deleting measures** When measures are deleted, spans of lyrics melismas and dashes involved (`LyricsLine`s) were not correctly adjusted. Also fixes the general case of removing or adding some time span intersecting `LyricsLine` spans. **Rewriting measures** while rewriting measures (as for time changes), existing `LyricsLine`s were left over and then re-added. Now they are deleted while removing measures (`InsertRemoveMeasures::removeMeasures()`).
lasconic
added a commit
that referenced
this pull request
Mar 10, 2015
…_measures Fix #48436 - Lyrics melisma and deleting measures / Fix #48491 - Ditto and time change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #48436 - Lyrics melisma and deleting measures / Fix #48491 - Ditto and time change
Deleting measures When measures are deleted, spans of lyrics melismas and dashes involved (
LyricsLines) were not correctly adjusted.Also fixes the general case of removing or adding some time span intersecting
LyricsLinespans.Rewriting measures while rewriting measures (as for time changes), existing
LyricsLines were left over and then re-added. Now they are deleted while removing measures (InsertRemoveMeasures::removeMeasures()).