Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

respect score "preferSharpFlat" setting of score, when initialise excerpt #18656

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

sammik
Copy link
Contributor

@sammik sammik commented Jul 17, 2023

Resolves: #18655

Also related to #18425 (main "declared issue - playback" was already fixed by #18500 but in fact, playback is only symptom, not core of issue)

transposing pitch have to respect concert pitch and prefer settings, otherwise tpc(1, or 2) may be wrong

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@sammik sammik changed the title respect score "preferSharpFlat" setting of part, when initialise excerpt respect score "preferSharpFlat" setting of score, when initialise excerpt Jul 17, 2023
@RomanPudashkin RomanPudashkin merged commit 76acd88 into musescore:master Jul 17, 2023
11 checks passed
@sammik sammik deleted the prefer-flat-sharp-parts branch July 17, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

prefer sharp flat setting lost in parts
3 participants