fix #35826: layout time sig on staff add #1868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lasconic
added a commit
that referenced
this pull request
Mar 11, 2015
fix #35826: layout time sig on staff add
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Either it's as simple as this - setting _needLayout when adding the time signature - or it's not worth doing for 2.0. But I think it really is this simple.
I checked the log of the issue whose fix led to this - http://musescore.org/en/node/14548. It seems this all had to do with the representation of the time signature, not the layout. So I rather seriously doubt that forcing the layout is going to break anything having to do with that. I did try to reproduce various aspects of that bug with my fix here in place, but couldn't get it to fail.