Fix special characters being lost in title frame texts when "cloning" to custom part #18712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomanPudashkin
approved these changes
Jul 21, 2023
|
Tested on Mac OS 11.6.5, Ubuntu 20.04.6, Windows 11 |
Actually it did nothing more than this. Next question: is that actually desired?
cbjeukendrup
force-pushed
the
lost_chars_clone_text_custom_part
branch
from
c8de23b
to
3f8cf2e
Compare
|
@mike-spa The last commit (especially the question in the commit message) might be relevant for your score/parts work. I'll merge this PR as it is right now, because it only simplifies the code but doesn't change the behaviour, but this might need to be discussed and changed in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #18709
(actually, it's not when really cloning)
(I accidentally added some fixes for some QML warnings because I was annoyed by them)