Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New score and parts interactions #18722

Merged
merged 14 commits into from
Sep 26, 2023
Merged

New score and parts interactions #18722

merged 14 commits into from
Sep 26, 2023

Commits on Sep 25, 2023

  1. New score and parts interactions

    @mike-spa @cbjeukendrup
    mike-spa authored and cbjeukendrup committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    9f3d216 View commit details
    Browse the repository at this point in the history

  2. Fix unit tests 

    The large diffs are due to:
- Increased file version to 4.20
- Introduction of the new property "Exclude from other parts". The property now defaults to true for frames, but we set it to false for frames done pre-4.2 for compatibility.
    @mike-spa @cbjeukendrup
    mike-spa authored and cbjeukendrup committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    52c9873 View commit details
    Browse the repository at this point in the history

  3. New unit tests

    @mike-spa @cbjeukendrup
    mike-spa authored and cbjeukendrup committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    508465f View commit details
    Browse the repository at this point in the history

  4. Add missing include

    @cbjeukendrup
    cbjeukendrup committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    de064db View commit details
    Browse the repository at this point in the history

  5. Code review fixes - clean up PropertyToggle

    @cbjeukendrup
    cbjeukendrup committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    7a60376 View commit details
    Browse the repository at this point in the history

  6. Code review fixes - simplify PartsSettings

    @cbjeukendrup
    cbjeukendrup committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    95ec349 View commit details
    Browse the repository at this point in the history

  7. Code review fixes - slightly simplify tests

    @cbjeukendrup
    cbjeukendrup committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    a64c014 View commit details
    Browse the repository at this point in the history

  8. Code review fixes - update code style in EngravingConfiguration

    @cbjeukendrup
    cbjeukendrup committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    1cad497 View commit details
    Browse the repository at this point in the history

  9. Code review fixes - a few more small ones

    @cbjeukendrup
    cbjeukendrup committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    c7d2055 View commit details
    Browse the repository at this point in the history

  10. Code review fixes - Move property group into PropertyMedaData

    @mike-spa @cbjeukendrup
    mike-spa authored and cbjeukendrup committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    e79f65d View commit details
    Browse the repository at this point in the history

  11. Code review fixes - Move method from MeasureBase to Box class

    @mike-spa @cbjeukendrup
    mike-spa authored and cbjeukendrup committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    8c23bf4 View commit details
    Browse the repository at this point in the history

  12. Code review fixes - more corrections

    @mike-spa @cbjeukendrup
    mike-spa authored and cbjeukendrup committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    c35963f View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2023

  1. Last small code review fixes

    @cbjeukendrup
    cbjeukendrup committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    c51ec22 View commit details
    Browse the repository at this point in the history

  2. Const perfectionism 

    (a little bit)
    @cbjeukendrup
    cbjeukendrup committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    64cbb5b View commit details
    Browse the repository at this point in the history