Fix #18777: Crash when showing accidentals for trill on tied notes #18780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eism
approved these changes
Jul 24, 2023
|
Tested #18777 on Win10, Mac13, LinuxUbuntu 22.04 - FIXED |
Eism
added a commit
that referenced
this pull request
Jul 24, 2023
Port #18780: Fix crash for trills with accidentals on tied notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #18777
As far as I could see, the grace note has nothing to do with the crash, it is all about the tie. One should check that the end note exists (it may not) before using it here. That already fixes the crash. But also, the ornament should actually ignore the tie when cloning the main note, here.
The new vtest I've added is expected to crash on current master.