Allow more flexibility for Spanners to compute start and end segment #18904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-spa
force-pushed
the
fix#18644Crashwhenmovingtempolinesinparts
branch
from
21f6bd0
to
0b5131f
Compare
mike-spa
force-pushed
the
fix#18644Crashwhenmovingtempolinesinparts
branch
2 times, most recently
from
5e3e80f
to
9fd2fab
Compare
oktophonie
approved these changes
Sep 21, 2023
Start segment: if a segment is not found to the right of this tick, allow looking to the left. End segment: system-line spanners should be allowed to terminate on segments that aren't necessarily ChordRest (for example, they can terminate on bar lines). correction
mike-spa
force-pushed
the
fix#18644Crashwhenmovingtempolinesinparts
branch
from
9fd2fab
to
bde4316
Compare
cbjeukendrup
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #18644
As @cbjeukendrup said, the definitive solution to these kinds of bugs will come when we do #16796. In the meantime, this is still a good thing to do, i.e. make spanners more flexible when computing their start/end segment.