Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #19073: tremolo beam thickness consistent with notehead size #19129

Merged
merged 2 commits into from
Aug 24, 2023

Conversation

miiizen
Copy link
Contributor

@miiizen miiizen commented Aug 22, 2023

Resolves: #19073

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@oktophonie
Copy link
Contributor

Can we extend this fix to solve the scaling problem on resized staves too?
image
It looks like the stem lengths on the upper stave (just a normal 'Small stave' here) are correct but the tremolo thickness/spacing is not.

@oktophonie oktophonie added the vtests This PR produces approved changes to vtest results label Aug 24, 2023
@RomanPudashkin RomanPudashkin merged commit e012fe3 into musescore:master Aug 24, 2023
10 of 11 checks passed
@miiizen miiizen deleted the 19073-tremolo-thickness branch August 24, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vtests This PR produces approved changes to vtest results
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Too thick beam of tremolo when noteheads are small
4 participants