Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #17655: Style dialog allows negative values for ottava hook heigh… #19162

Merged
merged 2 commits into from
Aug 31, 2023

Conversation

miiizen
Copy link
Contributor

@miiizen miiizen commented Aug 24, 2023

…ts consistent with inspector

Resolves: #17655

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@Jojo-Schmitz
Copy link
Contributor

I don't think we want any of the hight and width changes

@miiizen
Copy link
Contributor Author

miiizen commented Aug 25, 2023

These were added by Qt Creator, I believe to make space for the negative sign that can now appear in the box

@Jojo-Schmitz
Copy link
Contributor

That'd be width only, not height.

@cbjeukendrup
Copy link
Contributor

Qt Creator always does that, whenever making any change. I'm not sure if these changes matter anything, but I usually discard them.

@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Aug 25, 2023

That's what I do to (unless I change the dialog substantially), and recommend in this case too

@RomanPudashkin RomanPudashkin merged commit 992cf63 into musescore:master Aug 31, 2023
11 checks passed
@miiizen miiizen deleted the 17655-ottava-hook-below branch January 9, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Hook Height Below" in Ottava style definition points in the wrong direction
5 participants