Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial jack-audio support #19209

Merged
merged 1 commit into from
Aug 31, 2023
Merged

initial jack-audio support #19209

merged 1 commit into from
Aug 31, 2023

Conversation

lyrra
Copy link
Contributor

@lyrra lyrra commented Aug 29, 2023

Jack-audio support.
Enabled at build-time by selecting MUE_ENABLE_AUDIO_JACK=ON, ie no run-time selection support between jack/alsa.

  • [x ] I signed the CLA

TODO:

  • hangs jackd (which cant recover even after musescore is killed) (can't name client "default")
  • outputs audio to jack, but it is butched (was counting frames vs bytes)

Try it out:

  1. start jackd with MuseScores default 44100Hz:
    jackd -r -d dummy -r 44100
    (If using the dummy driver, record the audio using jack_capture).
  2. start MuseScore
  3. jack-connect musescore to jack's default output
    This is heusteristics that Mu3 did, but maybe should be handled by environment/setup managers such as Carla.
    $ jack_connect MuseScore:audio_out_right system:playback_2
    $ jack_connect MuseScore:audio_out_left system:playback_1
    

CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
@lyrra lyrra force-pushed the jack branch 3 times, most recently from 82668c8 to 1d448e6 Compare August 31, 2023 07:28
@lyrra lyrra marked this pull request as ready for review August 31, 2023 08:00
@igorkorsukov
Copy link
Contributor

@lyrra Now the choice of the driver is made at the compilation stage, respectively, Jack support will not be included in the release builds.
Do you plan to add driver selection at runtime, to the settings?

@lyrra
Copy link
Contributor Author

lyrra commented Aug 31, 2023

(squashed commits for cleaner history).

No plans so far on adding runtime selection support between jack and alsa.
Because that requires more in-depth understanding and perhaps UI-design.

@igorkorsukov igorkorsukov merged commit b4607ac into musescore:master Aug 31, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants