-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial jack-audio support #19209
Merged
Merged
initial jack-audio support #19209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f518cec
to
5787c98
Compare
82668c8
to
1d448e6
Compare
igorkorsukov
approved these changes
Aug 31, 2023
@lyrra Now the choice of the driver is made at the compilation stage, respectively, Jack support will not be included in the release builds. |
(squashed commits for cleaner history). No plans so far on adding runtime selection support between jack and alsa. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jack-audio support.
Enabled at build-time by selecting MUE_ENABLE_AUDIO_JACK=ON, ie no run-time selection support between jack/alsa.
TODO:
hangs jackd (which cant recover even after musescore is killed)(can't name client "default")outputs audio to jack, but it is butched(was counting frames vs bytes)Try it out:
jackd -r -d dummy -r 44100
(If using the dummy driver, record the audio using jack_capture).
This is heusteristics that Mu3 did, but maybe should be handled by environment/setup managers such as Carla.