Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always place accents on grace notes at notehead side #19228

Merged
merged 2 commits into from
Aug 31, 2023

Conversation

miiizen
Copy link
Contributor

@miiizen miiizen commented Aug 30, 2023

Resolves: #18726

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@oktophonie oktophonie changed the title Always place accents under grace notes Always place accents on grace notes at notehead side Aug 30, 2023
@oktophonie oktophonie added the vtests This PR produces approved changes to vtest results label Aug 30, 2023
@RomanPudashkin RomanPudashkin merged commit 2f305ed into musescore:master Aug 31, 2023
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vtests This PR produces approved changes to vtest results
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Correct accent direction placement on grace notes
3 participants