fix #53936: incomplete MusicXML text for 7sus4 #1923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Regarding the sus chord, I guess it would make sense to have a test case that read MusicXML, write it and compare with the reference one for chord symbols no? |
lasconic
added a commit
that referenced
this pull request
Apr 7, 2015
fix #53936: incomplete MusicXML text for 7sus4
|
Seems like it. The import changes are done now? |
|
Mostly. You can do a PR and mention Leon in it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, for 7sus4, we exported kind of suspended-fourth, text of "sus4", and the 7 was a degree tag with no specific text. We import this just fine, but other applications apparently would interpret this as "sus4add9". So on advice of Michael Good, we now export the kind text as "7sus4", and explicitly set the degree text for the 7 to "". Similarly for 9sus4 etc.
This PR also fixes a chord parsing issue where we would try to parse b913 as b 913, rather than b9 13, potentially leading to a crash.