Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it possible to apply alternate tuning symbols (guitar) #19308

Merged
merged 19 commits into from
Oct 18, 2023
Merged

Make it possible to apply alternate tuning symbols (guitar) #19308

merged 19 commits into from
Oct 18, 2023

Conversation

Eism
Copy link
Contributor

@Eism Eism commented Sep 6, 2023 •
edited

Resolves: #16804

  • Fix positioning of string tunings element - at the beginning of the measure
  • Fix font of string tunings element
  • Add tuning fork as a default symbol (if all strings hidden in popup)

@Eism Eism force-pushed the guitar_features_tunings branch 3 times, most recently from 7610712 to 27fb6be Compare September 10, 2023 17:57
RomanPudashkin
RomanPudashkin reviewed Sep 12, 2023
View reviewed changes
src/engraving/dom/edit.cpp
StringTunings* stringTunings = toStringTunings(ne);
const StringData* stringData = stringTunings->part()->stringData(tick);
int frets = stringData->frets();
std::vector<mu::engraving::instrString> stringList = stringData->stringList();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const std::vectormu::engraving::instrString&

@Eism Eism force-pushed the guitar_features_tunings branch 2 times, most recently from dd8df0a to 54057d4 Compare September 15, 2023 06:07
@abariska abariska mentioned this pull request Oct 17, 2023
Closed
@abariska
Copy link

🟢 Tested
Please, merge to master

@Eism Eism merged commit 4c61b2e into musescore:master Oct 18, 2023
11 checks passed
@Eism Eism deleted the guitar_features_tunings branch October 18, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RomanPudashkin RomanPudashkin RomanPudashkin approved these changes

Assignees

@abariska abariska

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Make it possible to apply alternate tuning symbols (guitar)
4 participants
@Eism @abariska @RomanPudashkin @mike-spa