Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose class BarLine with property barLineType to scripting #1931

Closed
wants to merge 2 commits into from

Conversation

heuchi
Copy link
Contributor

@heuchi heuchi commented Apr 8, 2015

This exposes BarLine and the BarLineType enum the same way as AccidentalType is exposed (using a QmlBarLineType enum).
While trying to use the barLineType property, I noticed that class BarLine was not yet registered in mscore.cpp.

Once again needed for my courtesy accidental plugin.

@Jojo-Schmitz
Copy link
Contributor

We can't use Ms::BarLineType for this?

@heuchi
Copy link
Contributor Author

heuchi commented Apr 9, 2015

Unfortunately we can't.
See this thread from the developer mailing list.
There has been some discussion about this issue already, but since Werner has recently moved some enums (AccidentalType, AccidentalRole) out of class Accidental (which was a rather large commit), I followed the model he used then.

@heuchi
Copy link
Contributor Author

heuchi commented Apr 13, 2015

As requested by Werner I added a test in tst_scripting if BarLineType and QmlBarLineType match.
I hope this is the place to do this.

@heuchi heuchi force-pushed the plugin-barline-type branch 2 times, most recently from 14392a9 to 9997c66 Compare April 13, 2015 14:33
@heuchi
Copy link
Contributor Author

heuchi commented Apr 22, 2015

@lasconic any chance this is going to be included in v2.0.1?

@lasconic
Copy link
Contributor

So far I didn't merge anything regarding the new way to expose enums in 2.0.1 or the new scripting tests. So no, unlikely as it is right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants