Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #18798: corrects system bracket display in continuous view #19316

Merged

Conversation

mmeyn
Copy link

@mmeyn mmeyn commented Sep 7, 2023

Resolves: #18798

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@cbjeukendrup
Copy link
Contributor

@mmeyn A rebase is needed, after #19330 was merged

@mmeyn mmeyn force-pushed the 18798-system-brackets-hidden-staves branch 2 times, most recently from 9c8e587 to a2be33a Compare September 12, 2023 15:11
@mmeyn mmeyn force-pushed the 18798-system-brackets-hidden-staves branch from a2be33a to 56fa3cc Compare September 12, 2023 15:12
@mmeyn
Copy link
Author

mmeyn commented Sep 12, 2023

Did a rebase, then corrected white-space errors from manual merging and pushed again. Now it should be fine.

@cbjeukendrup cbjeukendrup merged commit eb641ae into musescore:master Sep 14, 2023
11 checks passed
@mmeyn mmeyn deleted the 18798-system-brackets-hidden-staves branch September 25, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

System brackets messed up in horizontal continuous view
3 participants