Update drum staff when editing kit #19335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbjeukendrup
reviewed
Sep 8, 2023
| @@ -626,6 +626,10 @@ void NotationParts::replaceDrumset(const InstrumentKey& instrumentKey, const Dru | |||
|
|
|||
| score()->undo(new mu::engraving::ChangeDrumset(instrument, &newDrumset)); | |||
|
|
|||
| if (part->staves().size() > 0) { | |||
| score()->setLayout(Fraction(0, 1), score()->endTick(), part->staves().front()->idx(), part->staves().back()->idx()); | |||
There was a problem hiding this comment.
Wouldn't this need to be done inside the engraving module, so that it is also triggered on undo/redo?
miiizen
force-pushed
the
18886-drumset-update
branch
from
0f5e4fc
to
87bfad6
Compare
oktophonie
approved these changes
Sep 11, 2023
RomanPudashkin
approved these changes
Sep 11, 2023
|
Tested on Mac OS 11.6.5, Ubuntu 20.04.6, Windows 11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #18886
Opted for
score()->setLayout()overscore()->layoutAll()to only re-layout percussion staves