partial fix for #51271: timesig and barline issues on 1-line staves #1934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The second part is pretty straight straightforward too - basically just a matter of adding some more special cases for 1-line staves. We need to do it not just when reading the score, but also when editing barlines, and also when changing number of staff lines. The system initial barline code is different enough that I'll deal with that in a separate commit, assuming I figure it out at all. |
MarcSabatella
changed the title
lasconic
added a commit
that referenced
this pull request
Apr 10, 2015
partial fix for #51271: timesig and barline issues on 1-line staves
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This part of the fix is simple enough - we need to layout the newly added time signature.
The issue also describes issues with barlines on one-line staves. I am less sure how to fix those, but figured I'd submit the timesig fix first as is.