Fix GH#19371: Set text line's text color #19393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 13, 2023
Jojo-Schmitz
changed the title
Jojo-Schmitz
force-pushed
the
symbol-colour
branch
4 times, most recently
from
c8da0ae
to
619fb65
Compare
|
Now the vtests here "fail" in the same way as in #19354: |
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 14, 2023
oktophonie
approved these changes
Sep 14, 2023
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 14, 2023
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 14, 2023
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 14, 2023
cbjeukendrup
previously approved these changes
Sep 15, 2023
cbjeukendrup
dismissed
their stale review
The changes need to be made in dev, not stable
Jojo-Schmitz
force-pushed
the
symbol-colour
branch
2 times, most recently
from
774bce5
to
393a149
Compare
Jojo-Schmitz
force-pushed
the
symbol-colour
branch
from
393a149
to
d8b0841
Compare
cbjeukendrup
approved these changes
Sep 18, 2023
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 18, 2023
alexpavlov96
pushed a commit
to alexpavlov96/MuseScore
that referenced
this pull request
Sep 19, 2023
Fix GH#19371: Set text line's text color
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #19371
IMHO better than #19391, as it also changes the texts on a change of the line color directly and not only after save/close/reopen