Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Realize the basic functions of Jianpu #19395

Closed
wants to merge 7 commits into from
Closed

Realize the basic functions of Jianpu #19395

wants to merge 7 commits into from

Conversation

Auase
Copy link

@Auase Auase commented Sep 13, 2023

Resolves: #NNNNN

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@Auase
Copy link
Author

Auase commented Sep 14, 2023

jianpu
The characters added to Leland were copied from Edwin-Bold. I tried adding independent font files, but the amount of code that needed to be changed was too much, so I gave up the plan of adding font files.
f
e

@Auase Auase marked this pull request as draft September 14, 2023 08:05
@oktophonie
Copy link
Contributor

This is amazing!

I don't think extending Leland is a great idea, though. However, if you don't want to create a separate font file, and only text characters are being used, is it not possible to use the text font directly? (Which may be Edwin by default, but could be configurable so users could choose whatever font they like)

@Auase
Copy link
Author

Auase commented Sep 14, 2023

@oktophonie
I understand, I have tried, but I cannot solve the problem of program lag. Of course, this is just my personal technical issue, and if you can implement it, it would be the best.

@oktophonie
Copy link
Contributor

Unfortunately we can't make changes to Leland in this PR; that would have to be done in the Leland repo separately, and I don't want to do that anyway since it ties Leland and Edwin together. So, as it is, we cannot merge this PR until it uses a text font directly, or possibly even a custom font especially for Jianpu.

@Auase
Copy link
Author

Auase commented Sep 14, 2023

This only provides a display method and does not involve audio (as Jianpu does not require audio and specific instruments). Elements that do not need to be written to the music file have been excluded as much as possible, so it will not affect the normal opening of music in other versions.

@Auase
Copy link
Author

Auase commented Sep 14, 2023

@oktophonie
I am unable to implement it because I don't know how to make Jianpu change the default to use a different font file. Can you help me?

@Auase Auase marked this pull request as ready for review September 14, 2023 11:19
@Auase Auase closed this Sep 16, 2023
@Auase

This comment was marked as outdated.

@musescore musescore deleted a comment from Jojo-Schmitz Sep 18, 2023
@musescore musescore deleted a comment from Jojo-Schmitz Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants