New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Realize the basic functions of Jianpu #19395
Conversation
This is amazing! I don't think extending Leland is a great idea, though. However, if you don't want to create a separate font file, and only text characters are being used, is it not possible to use the text font directly? (Which may be Edwin by default, but could be configurable so users could choose whatever font they like) |
@oktophonie |
Unfortunately we can't make changes to Leland in this PR; that would have to be done in the Leland repo separately, and I don't want to do that anyway since it ties Leland and Edwin together. So, as it is, we cannot merge this PR until it uses a text font directly, or possibly even a custom font especially for Jianpu. |
This only provides a display method and does not involve audio (as Jianpu does not require audio and specific instruments). Elements that do not need to be written to the music file have been excluded as much as possible, so it will not affect the normal opening of music in other versions. |
@oktophonie |
Resolves: #NNNNN